Skip to content

feat: warn when using SET commands not being the top decl - #508

Merged
bashbunni merged 2 commits into
charmbracelet:mainfrom
Delta456:set_warn_not_top_decl
Oct 18, 2024
Merged

bashbunni merged 2 commits into
charmbracelet:mainfrom
Delta456:set_warn_not_top_decl

Conversation

@Delta456

Copy link
Copy Markdown
Contributor

This PR adds a warning when using the SET commands after the top declaration.

Agreed, if a setting is ignored we should display a warning that this setting should appear at the top of the file!
Originally posted by @maaslalani in #503 (comment)

@Delta456
Delta456 requested a review from maaslalani as a code owner July 26, 2024 11:17
@bashbunni

Copy link
Copy Markdown
Contributor

Just tweaked the wording a bit. Thank you so much for the contribution :)
image

@bashbunni
bashbunni merged commit 2ff7bbd into charmbracelet:main Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址