Skip to content

RingsRight is not a valid bar style #543

Closed

Description

@popey

Describe the bug

The following configuration in a tape file is parsed as invalid, despite being in the documentation as one of the valid options (Colorful, Rings, ColorfulRight, and RingsRight).

Set WindowBar RingsRight

Setup

  • OS macOS & Ubuntu
  • Shell zsh
  • Terminal Emulator Alacritty
  • Terminal Multiplexer none

To Reproduce

  1. Add Set WindowBar RingsRight to a tape file
  2. Run vhs
$ vhs test.tape
File: test.tape
  3 │ Set WindowBar RingsRight
                    ^^^^^^^^^^ RingsRight is not a valid bar style.

parser: 1 error(s)
recording failed

Source Code

$ cat test.tape
Output "demo.gif"
Set WindowBar RingsRight
Set FontSize 46
Set Width 1200
Set Height 600
Type echo 'Welcome to VHS!'
Sleep 500ms
Enter 1
Sleep 5s

Expected behavior

vhs should validate the tape file correctly and begin recording a gif.

Screenshots

image

Additional context

The issue is a typo in https://github.com/charmbracelet/vhs/blob/main/parser/parser.go#L771

// Check if a given windowbar type is valid
func isValidWindowBar(w string) bool {
	return w == "" ||
		w == "Colorful" || w == "ColorfulRight" ||
		w == "Rings" || w == "RightsRight"
}

RightsRight should be RingsRight

Activity

  1. added a commit that references this issue on Dec 4, 2024
    ecc1150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址