Repository navigation
fix: prevent wrapping nil error on successful SMTP delivery - #169
Merged
Merged
Conversation
The previous code was unconditionally returning an error (regardless of whether the call had succeeded or not)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression introduced during a recent refactoring or linting pass where a successful SMTP delivery returns a
sending email: %!w(<nil>)error message.This PR adds an explicit
nilcheck before attempting to annotate the error with context.Changes
nilimmediately if the delivery was successful.fmt.Errorfif an actual failure occurred.Verification
%!w(<nil>)to stderr, and the process exits with status0.CONTRIBUTING.md.