[alexvelea]

• added small unittest to highlight the problem
• problem only visible when running with -race option

[codecov]

Codecov Report

Merging #64 (e11ecdd) into main (31d2a53) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   76.77%   76.85%   +0.07%     
==========================================
  Files          10       10              
  Lines         633      635       +2     
==========================================
+ Hits          486      488       +2     
  Misses        132      132              
  Partials       15       15              

Impacted Files	Coverage Δ
logger.go	82.75% <100.00%> (+0.17%)	⬆️

[aymanbagabas]

Hi @alexvelea, thanks for the PR. I'm not able to reproduce the issue on main using go test -race ./..., I'm using macOS to test this.

[alexvelea]

Hi @alexvelea, thanks for the PR. I'm not able to reproduce the issue on main using go test -race ./..., I'm using macOS to test this.

Thanks for the fast reply @aymanbagabas
Did you undo the fix before? (from the logger.go file)
I'm using the same command on my end. macOS M1

[aymanbagabas]

Thanks for the fast reply @aymanbagabas Did you undo the fix before? (from the logger.go file) I'm using the same command on my end. macOS M1

I'm testing it against the latest commit from main:

~/Source/charmbracelet/log main*
› git rev-parse HEAD
31d2a537b4d27b2d45169051aeb48b35c2712398

~/Source/charmbracelet/log main*
› go test -race ./...
ok      github.com/charmbracelet/log    0.241s

[alexvelea]

@aymanbagabas, could you try again now, please?

[alexvelea]

Also, make sure to run the tests on this branch.
The main branch passes, but I've added a new test here (as well a fix, which is now rollbacked)

[aymanbagabas]

@alexvelea Ahh I see the issue now, could you re-push your changes again?

[alexvelea]

@aymanbagabas done, tests are fixed now