Repository navigation
slog: Don't log if not enabled at level - #103
Merged
Merged
Conversation
aymanbagabas
reviewed
Feb 5, 2024
Contributor
|
@imjasonh Good catch! Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very naive first attempt to fix a potential bug I noticed in this package's integration with slog.
When I used
I was still seeing
INFOandDEBUlogs, and I couldn't figure out why. I think this is the cause -- the slogHandlemethod isn't consultingEnabledbefore handling. slog's builtin Text and JSON handlers consult the enabled level before logging.Patching this locally fixed the issue for me, so I thought I'd contribute it. Please let me know if this is on the wrong track.