Repository navigation
fix: Terminal.app rendering issues - #643
Merged
Merged
Conversation
caarlos0
requested review from
andreynering,
aymanbagabas,
Copilot and
meowgorithm
April 29, 2025 19:59
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix Terminal.app rendering issues by replacing the use of lipgloss.JoinVertical/JoinHorizontal with strings.Join for constructing multi-line views, and by renaming auxiliary height functions to better reflect their purpose.
- Replaces lipgloss join functions with strings.Join (using "\n" as a separator) to improve rendering
- Renames nonContentHeight to titleFooterHeight and refactors height calculation in WithHeight
- Simplifies height comparison in form Update using a max helper function
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| layout.go | Updated view functions to join lines via strings.Join |
| group.go | Renamed nonContentHeight to titleFooterHeight and updated join calls |
| form.go | Replaced manual height check with a max helper function |
| field_text.go | Updated to use strings.Join for view rendering |
| field_select.go | Updated to use strings.Join for view rendering |
| field_filepicker.go | Updated to use strings.Join for view rendering |
Comments suppressed due to low confidence (3)
group.go:129
- [nitpick] The function previously named nonContentHeight has been renamed to titleFooterHeight; consider updating inline comments or documentation to clearly explain the rationale behind the new name.
h := height - g.titleFooterHeight()
layout.go:81
- [nitpick] Ensure that replacing lipgloss.JoinVertical with strings.Join preserves the intended vertical alignment and styling for Terminal.app, as the lipgloss function may provide extra formatting logic.
return strings.Join([]string{
form.go:543
- [nitpick] Using a max helper function simplifies the height comparison; please verify that the max function is correctly defined and handles any necessary edge cases.
neededHeight = max(neededHeight, group.rawHeight())
andreynering
approved these changes
Apr 29, 2025
aymanbagabas
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #631