Skip to content

fix: accessible mode IO, default values, and more - #614

Merged
caarlos0 merged 17 commits into
mainfrom
accessible
Apr 9, 2025
Merged

caarlos0 merged 17 commits into
mainfrom
accessible

Conversation

@caarlos0

@caarlos0 caarlos0 commented Apr 3, 2025 •

Copy link
Copy Markdown
Contributor
  • fixed I/O in accessibility mode
  • text didn't echo the user input after submit (whereas the other components did)
  • fixed default value on confirm in accessible mode
  • fixed a non-set CharLimit of 0 being considered in the Text component

closes #612
closes #615

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Apr 3, 2025
@caarlos0
caarlos0 marked this pull request as ready for review April 3, 2025 17:08
@caarlos0
caarlos0 requested a review from a team as a code owner April 3, 2025 17:08
@caarlos0
caarlos0 requested review from bashbunni and removed request for a team April 3, 2025 17:08
@caarlos0 caarlos0 added the bug Something isn't working label Apr 3, 2025
Comment thread accessibility/accessibility.go Resolved
caarlos0 and others added 4 commits April 7, 2025 10:11
* fix: accessible default confirm value

closes #615

* test: fix

* fix: trim space

* Apply suggestions from code review

Co-authored-by: Andrey Nering <andreynering@users.noreply.github.com>

---------

Co-authored-by: Andrey Nering <andreynering@users.noreply.github.com>
The ./accessibility pkg was never supposed to be public IMHO.
We should remove it in v2.

That said, kept it there for now.

@bashbunni bashbunni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of lint complaints on the tests, but looks good to me :)

Comment thread field_confirm.go Resolved
Comment thread form.go Resolved
@bashbunni

bashbunni commented Apr 7, 2025 •

Copy link
Copy Markdown
Contributor

extra newline in burger example "special instructions"
image

Also, should we show that was chosen if the option was invalid? e.g. this would say "Chose: Fishburger" then "no fish today, sorry"
image

caarlos0 and others added 3 commits April 9, 2025 10:23
Co-authored-by: bashbunni <15822994+bashbunni@users.noreply.github.com>
@caarlos0

caarlos0 commented Apr 9, 2025

Copy link
Copy Markdown
Contributor Author

thanks @bashbunni! Fixed 🙏🏻

@caarlos0 caarlos0 changed the title fix: accessible IO fix: accessible mode IO, default values, and more Apr 9, 2025
@caarlos0
caarlos0 requested a review from andreynering April 9, 2025 20:46
@caarlos0
caarlos0 merged commit c590663 into main Apr 9, 2025
@caarlos0
caarlos0 deleted the accessible branch April 9, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessible Confirm prompt does not treat Value as default Accessible prompts ignore configured stdio streams

3 participants

⌂ 换网址