Repository navigation
fix: accessible mode IO, default values, and more - #614
Merged
Merged
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
andreynering
reviewed
Apr 7, 2025
* fix: accessible default confirm value closes #615 * test: fix * fix: trim space * Apply suggestions from code review Co-authored-by: Andrey Nering <andreynering@users.noreply.github.com> --------- Co-authored-by: Andrey Nering <andreynering@users.noreply.github.com>
The ./accessibility pkg was never supposed to be public IMHO. We should remove it in v2. That said, kept it there for now.
bashbunni
approved these changes
Apr 7, 2025
bashbunni
left a comment
Contributor
There was a problem hiding this comment.
There are a couple of lint complaints on the tests, but looks good to me :)
Contributor
Co-authored-by: bashbunni <15822994+bashbunni@users.noreply.github.com>
Contributor
Author
|
thanks @bashbunni! Fixed 🙏🏻 |
andreynering
approved these changes
Apr 9, 2025
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
andreynering
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


CharLimitof0being considered in the Text componentcloses #612
closes #615