Skip to content

Refactored option rendering in field_select.go to improve distinction - #304

Merged
meowgorithm merged 1 commit into
mainfrom
csandeep_patch_1_issue_614
Jul 11, 2024
Merged

meowgorithm merged 1 commit into
mainfrom
csandeep_patch_1_issue_614

Conversation

@csandeep

Copy link
Copy Markdown
Contributor

Fixed rendering of unselected options in the select field. Previously, all options were displayed with the same style regardless of their selection state. Now, unselected options will be appropriately rendered with an 'UnselectedOption' style.

ref: charmbracelet/gum#614

@csandeep
csandeep requested a review from maaslalani as a code owner July 11, 2024 19:02
@meowgorithm
meowgorithm self-requested a review July 11, 2024 19:12

@meowgorithm meowgorithm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meowgorithm
meowgorithm merged commit dbf5a5a into main Jul 11, 2024
@meowgorithm
meowgorithm deleted the csandeep_patch_1_issue_614 branch July 11, 2024 19:15
renovate Bot referenced this pull request in jippi/dottie Jul 25, 2024
….mod (#67)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/charmbracelet/huh](https://togithub.com/charmbracelet/huh)
| `v0.5.1` -> `v0.5.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fcharmbracelet%2fhuh/v0.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fcharmbracelet%2fhuh/v0.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fcharmbracelet%2fhuh/v0.5.1/v0.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fcharmbracelet%2fhuh/v0.5.1/v0.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charmbracelet/huh (github.com/charmbracelet/huh)</summary>

###
[`v0.5.2`](https://togithub.com/charmbracelet/huh/releases/tag/v0.5.2)

[Compare
Source](https://togithub.com/charmbracelet/huh/compare/v0.5.1...v0.5.2)

### Lil’ fixes ’n’ improvements

Hi! This is a maintenance release to fix issues with dynamic forms as
well as address issues with
[Gum](https://togithub.com/charmbracelet/gum) upstream.

#### Changelog

##### New

- add accept and reject key bindings to confirm by
[@&#8203;csandeep](https://togithub.com/csandeep) in
[https://github.com/charmbracelet/huh/pull/308](https://togithub.com/charmbracelet/huh/pull/308)
- allow Generic `T` updateOptionsMsg by
[@&#8203;maaslalani](https://togithub.com/maaslalani) in
[https://github.com/charmbracelet/huh/pull/318](https://togithub.com/charmbracelet/huh/pull/318)

##### Fixed

- improve distinction in field select by
[@&#8203;csandeep](https://togithub.com/csandeep) in
[https://github.com/charmbracelet/huh/pull/304](https://togithub.com/charmbracelet/huh/pull/304)
- fix invalid order of event handling in input/text fields by
[@&#8203;Sculas](https://togithub.com/Sculas) in
[https://github.com/charmbracelet/huh/pull/284](https://togithub.com/charmbracelet/huh/pull/284)

#### New Contributors

- [@&#8203;csandeep](https://togithub.com/csandeep) made their first
contribution in
[https://github.com/charmbracelet/huh/pull/304](https://togithub.com/charmbracelet/huh/pull/304)
-
[@&#8203;MaximilianSoerenPollak](https://togithub.com/MaximilianSoerenPollak)
made their first contribution in
[https://github.com/charmbracelet/huh/pull/313](https://togithub.com/charmbracelet/huh/pull/313)

**Full Changelog**:
charmbracelet/huh@v0.5.1...v0.5.2

***

<a href="https://charm.sh/"><img alt="The Charm logo"
src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a>

Thoughts? Questions? We love hearing from you. Feel free to reach out on
[Twitter](https://twitter.com/charmcli), [The
Fediverse](https://mastodon.technology/@&#8203;charm), or
[Discord](https://charm.sh/chat).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/jippi/dottie).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址