Repository navigation
Add release script to bump patch tag and trigger goreleaser pipeline - #968
Merged
Merged
Conversation
Also ensures the local self-hosted Actions runner is running, since the goreleaser job requires it.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84932b66a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address Codex review feedback on #968: - Refuse to tag unless HEAD is on RELEASE_BRANCH (default main), the working tree is clean, and local matches origin/main — otherwise a release from a feature branch or stale checkout would push a v* tag goreleaser.yml releases on. - Filter to strict vMAJOR.MINOR.PATCH tags before picking "latest", so a prerelease tag (e.g. v1.2.4-rc.1, allowed by this repo's `prerelease: auto` goreleaser config) can't be selected and abort the script instead of bumping the latest stable release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/release.sh: reads the latestvX.Y.Ztag, bumps the patch number, and pushes the new tag — which triggers.github/workflows/goreleaser.yml(fires onpush: tags: v*).~/cdalar/actions-runner/run.sh) is running (required since the goreleaser job runs on[self-hosted, macOS, ARM64]), and starts it if it isn't.Test plan
scripts/release.shon a test tag / dry environment to confirm patch bump logic