Repository navigation
fix(release): sign checksums with explicit GPG key in isolated keyring - #958
Merged
Merged
Conversation
The self-hosted release runner is persistent (not ephemeral), so the shared ~/.gnupg default keyring can end up in a state where gpg can't resolve an unambiguous default signing key, failing with "no default secret key: No public key". Import the key into a job-scoped GNUPGHOME and have goreleaser sign with the imported key's fingerprint explicitly instead of relying on gpg's default-key guess.
echo "$GNUPGHOME" >> "$GITHUB_ENV" wrote just the value with no key,
which GitHub's env-file parser rejects ("Invalid format"). Test run
against v0.1.30 caught this before it could hit a real release.
![chatgpt-codex-connector[bot]](/p/https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e2d1926b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 24.21% 24.21%
=======================================
Files 44 44
Lines 4440 4440
=======================================
Hits 1075 1075
Misses 3231 3231
Partials 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
GOCACHE/GOMODCACHE already persist on this runner's disk between runs since it's a long-lived machine, not ephemeral. Uploading/ downloading GitHub's remote Actions cache on top of that just adds several minutes of upload time for a multi-GB cache with no benefit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpg: no default secret key: No public keybecause the self-hosted release runner is persistent, not ephemeral — the shared~/.gnupgdefault keyring could end up without an unambiguous default signing key by the time GoReleaser ran.$RUNNER_TEMP/gnupginstead of the shared homedir, and have GoReleaser sign with the imported key's fingerprint explicitly (-u {{ .Env.GPG_FINGERPRINT }}) rather than relying on gpg's default-key guess.Test plan
goreleaser checkvalidates the updated.goreleaser.ymlgoreleaser-self-hosted-test.yml(workflow_dispatch against an existing tag) to confirm signing succeeds end-to-end before it hits a real tag push