[cdalar]

Summary

Follow-up to #954. After that PR merged, a live report from onctl -p fc ls on fc-hel1-01 (rebooted for a kernel upgrade) showed the orphaned microVM as paused — still wrong, just a different wrong status than before.

Root cause: #954's reconciliation persists a dead fc microVM's status as "stopped". But cmd/list.go's isPausedStatus() already treats the literal string "stopped" as the cross-provider paused/resumable convention:

func isPausedStatus(status string) bool {
	return status == "stopped" ||
		status == "TERMINATED" ||
		strings.Contains(strings.ToLower(status), "deallocated")
}

That's correct for AWS/GCP/Azure — a "stopped" EC2 instance or "deallocated" Azure VM still exists and can be resumed. It's not correct for fc: a microVM whose firecracker process died (e.g. host reboot) has no restart-from-disk — recovering it means destroy + recreate. Reusing "stopped" collided with that check and folded the dead microVM into onctl ls's PAUSED section, implying resumability it doesn't have — the exact kind of lie this whole fix exists to stop.

Changes

• Renames fcStatusStopped → fcStatusDead ("dead") throughout pkg/cloud/fc.go and the fc-specific duplicate-name check in cmd/create.go.
• Adds TestIsPausedStatus in cmd/list_test.go covering the AWS/GCP/Azure paused strings (true) alongside fc's "dead" (false), to lock in the distinction and catch any future status-string collision here.

Test plan

• go build ./...
• go vet ./...
• golangci-lint run ./cmd/... ./pkg/cloud/... — 0 issues
• go test ./pkg/cloud/... -run TestProviderFC — all passing (renamed assertions)
• go test ./cmd/... -run "TestIsPausedStatus|TestListCmd" — all passing, including the new regression test

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.21%. Comparing base (9ba7d86) to head (b11d445).

Files with missing lines	Patch %	Lines
cmd/create.go	0.00%	1 Missing ⚠️
pkg/cloud/fc.go	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
+ Coverage   24.12%   24.21%   +0.09%     
==========================================
  Files          44       44              
  Lines        4440     4440              
==========================================
+ Hits         1071     1075       +4     
+ Misses       3235     3231       -4     
  Partials      134      134              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.