Repository navigation
fix(hetzner): stop using deprecated Server.Datacenter to avoid nil panic - #951
Merged
Merged
Conversation
Uses onctl ssh --upload to transfer the linux/amd64 binary and installs it to /usr/local/bin/onctl.
Hetzner's API has stopped populating the deprecated Datacenter field on server responses, so server.Datacenter.Location.Name panicked with a nil pointer dereference in onctl ls. Use server.Location directly instead, matching hcloud-go's deprecation guidance.
![chatgpt-codex-connector[bot]](/p/https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8ff22dc7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…oller.sh The script invoked ./onctl to ssh/upload, but make build-amd64 only produces onctl-amd64 (a linux/amd64 cross-build). From a clean checkout the host binary didn't exist and the script failed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BADfF7936dPfssXqBXsLx3
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
=======================================
Coverage 23.94% 23.94%
=======================================
Files 44 44
Lines 4418 4418
=======================================
Hits 1058 1058
Misses 3229 3229
Partials 131 131 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onctl lspanicked with a nil pointer dereference (SIGSEGV addr=0x28) insidemapHetznerServerServer.Datacenterfield, soserver.Datacenter.Location.Namedereferenced a nil*Datacenterserver.Locationdirectly (already present onhcloud.Server) instead of going through the deprecatedDatacenter.Locationpath, at all three call sites inpkg/cloud/hetzner.goTest plan
go build ./...go vet ./pkg/cloud/...go test ./pkg/cloud/...