Repository navigation
feat: set Firecracker default memory to 4 GB - #938
Merged
Merged
Conversation
Default vcpu was already 1; raise memSizeMib default from 512 to 4096 in the flag, GetConfig fallback, and the shipped onctl.yaml template.
![chatgpt-codex-connector[bot]](/p/https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 142420e7e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
==========================================
- Coverage 24.03% 23.96% -0.07%
==========================================
Files 44 44
Lines 4402 4414 +12
==========================================
Hits 1058 1058
- Misses 3213 3225 +12
Partials 131 131 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The 4096 MiB guest default introduced in 142420e exceeds the RAM of the n1-standard-1 GCP host (3.75 GB) that README.md documents creating for the no-bare-metal Firecracker flow, leaving no room for host OS/Firecracker overhead. 2048 MiB fits comfortably while still improving on the original 512 MiB default. Flagged by Codex review on PR #938. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CEBC7inDoMfnhtjdG1M2Uy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--memoryflag default from 512 MiB to 4096 MiB (4 GB)GetConfig()fallback, the shippedonctl.yamlinit template, and testsTest plan
go test ./internal/providerfc/...passes (TestGetConfig_Defaultsnow asserts 4096)go test ./cmd/... -run TestCreateFlagsBindToViperpasses (flag default updated to 4096)onctl create --provider fcpicks up 4 GB without needing an explicit--memoryflag