Repository navigation
ci: replace dead gon notarization with quill - #923
Merged
Merged
Conversation
gon was disabled in cb8d07f (2023-11-06), likely when Apple deprecated the altool-based notarization flow it relied on. Every darwin release since has shipped unsigned/non-notarized. quill is cross-platform, needs no keychain, and supports notarytool-based notarization via API keys. Requires new repo secrets: QUILL_NOTARY_KEY, QUILL_NOTARY_KEY_ID, QUILL_NOTARY_ISSUER (App Store Connect API key). Reuses existing APPLE_DEVELOPER_CERTIFICATE_* secrets for signing.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
+ Coverage 22.62% 22.76% +0.14%
==========================================
Files 42 42
Lines 4182 4182
==========================================
+ Hits 946 952 +6
+ Misses 3117 3114 -3
+ Partials 119 116 -3 β View full report in Codecov by Harness. π New features to boost your workflow:
|
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gonrelied on. Every darwin release since (including the currentv0.1.26) has shipped unsigned/non-notarized.builds:matrix in.goreleaser.ymlintoonctl-macos(darwin, with aquill sign-and-notarizepost-hook) andonctl(linux/windows, unchanged).brew install gonCI steps with installingquill(cross-platform, no keychain required) in bothgoreleaser.ymlandgoreleaser-self-hosted-test.yml.gon/config-{amd64,arm64}.jsonfiles.Secrets required before this can notarize on a real release
APPLE_DEVELOPER_CERTIFICATE_P12_BASE64/APPLE_DEVELOPER_CERTIFICATE_PASSWORDforQUILL_SIGN_P12/QUILL_SIGN_PASSWORD.QUILL_NOTARY_KEY,QUILL_NOTARY_KEY_ID,QUILL_NOTARY_ISSUER.AC_PASSWORD(old Apple-ID app-specific password) is no longer used and can be removed once this merges.Test plan
goreleaser checkvalidates the configgoreleaser release --snapshot --clean --skip=publish,signconfirms thequillpost-hook fires only for darwin targets, not linux/windowsQUILL_NOTARY_*secretsspctl -a -vv/codesign -dv)