Repository navigation
feat: add recursive directory upload support via SFTP - #904
Merged
Merged
Conversation
Extends ProcessUploadSlice to detect directories and upload them recursively using a new SSHUploadDir method, with real-time progress reporting across all files in the tree. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](/p/https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ee042136c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
===========================================
+ Coverage 11.58% 22.05% +10.47%
===========================================
Files 36 41 +5
Lines 3115 4107 +992
===========================================
+ Hits 361 906 +545
- Misses 2710 3085 +375
- Partials 44 116 +72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Addresses codecov patch-coverage failure on PR #904 by exercising the new directory-upload code paths added for recursive SFTP uploads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSHUploadDirmethod toRemotethat recursively uploads a local directory via SFTPProcessUploadSliceto detect directories and route to the new methoddirSizehelper to pre-calculate total bytes for accurate progress reportingTest plan
🤖 Generated with Claude Code