[cdalar]

Problem

During onctl up, the VM IP line is shown twice:

✔ VM IP: 167.233.64.66
⢿  VM IP: 167.233.64.66

The bubbletea-based spinner wrapper (internal/ui/spinner.go) only syncs Suffix into the rendered model on Start()/Restart(), but the cmd code assigned s.Suffix after calling Start()/Restart() (the old briandowns/spinner pattern). So every phase's spinner rendered the previous phase's text — after printing ✔ VM IP: …, the spinner restarted for the cloud-init wait but kept displaying the stale VM IP: … suffix.

A second latent bug: SetSuffix() sent the updated model to the running program, but the tea model's Update() had no case to receive it, so mid-run suffix changes were silently dropped — which also left the deploy upload progress bar frozen.

Changes

• internal/ui/spinner.go: add a suffixMsg case to the tea model's Update so SetSuffix actually updates a running spinner
• cmd/create.go, cmd/deploy.go, cmd/ssh.go, cmd/destroy.go: set s.Suffix before Start()/Restart() at every call site
• deploy's upload progress callback now uses SetSuffix() so the progress bar updates live
• drop the pointless Restart()/Stop() pair around the VM IP println in create.go
• add TestModelUpdateSuffixMsg verifying suffix changes reach the renderer

Verification

• go build ./..., go vet clean
• full test suite passes; go test -race ./internal/ui/... passes
• golangci-lint run reports 0 issues
• grep confirms no remaining Start/Restart-before-Suffix orderings

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.57%. Comparing base (0257702) to head (fde3d70).

Files with missing lines	Patch %	Lines
cmd/create.go	0.00%	10 Missing ⚠️
cmd/deploy.go	0.00%	7 Missing ⚠️
cmd/destroy.go	0.00%	2 Missing ⚠️
cmd/ssh.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
+ Coverage   21.40%   21.57%   +0.16%     
==========================================
  Files          41       41              
  Lines        4031     4032       +1     
==========================================
+ Hits          863      870       +7     
+ Misses       3059     3054       -5     
+ Partials      109      108       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.