Repository navigation
feat(hetzner): add --image flag for OS image selection - #894
Merged
Merged
Conversation
Allows overriding the default image (ubuntu-22.04) via --image flag or the vm.image key in a --file config YAML, enabling images like fedora-42. https://claude.ai/code/session_01ENYN541Kp9NUsfqLwkvJPW
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c4b6ba037
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The flag was silently ignored on AWS/GCP/Azure since those providers never read Vm.Image. Surface a fatal error instead of creating a VM with a different image than requested. https://claude.ai/code/session_01KFkwuKLykNdjR4pCfXMsfa
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
==========================================
+ Coverage 13.91% 13.96% +0.05%
==========================================
Files 38 38
Lines 3429 3437 +8
==========================================
+ Hits 477 480 +3
- Misses 2900 2905 +5
Partials 52 52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--imageCLI flag toonctl createso users can specify any Hetzner OS image (e.g.fedora-42,ubuntu-24.04) instead of being locked to the defaultimagefield to theVmstruct with yaml tag, so it can also be set via--fileconfig YAMLDeploy()uses the per-request image when provided, falling back tohetzner.vm.imagefrom the config fileMergeConfig()respects the image field with the same CLI-takes-precedence semantics as other fieldsUsage
The default (
ubuntu-22.04from~/.onctl/hetzner.yaml) is unchanged when--imageis not specified.Generated by Claude Code