Repository navigation
refactor: move internal/cloud to pkg/cloud - #880
Merged
Merged
Conversation
cdalar
enabled auto-merge (squash)
June 4, 2026 20:18
Makes the cloud provider package importable from external modules (e.g. onctl-platform SaaS backend). The internal/ restriction only blocked the Go compiler, not source visibility β the repo is public either way, so there is no security benefit to keeping it internal. All import paths updated; build and tests confirmed clean.
cdalar
force-pushed
the
worktree-pkg-cloud-rename
branch
from
June 4, 2026 20:18
282af94 to
7bd95d3
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/cloud/βpkg/cloud/cmd/internal/cloud/Why
internal/in Go only blocks the compiler β it doesn't hide source code since the repo is public. The restriction was preventingonctl-platform(the private SaaS backend) from importingProviderHetznerandCloudProviderInterfacedirectly.Moving to
pkg/cloud/makes it a proper public library API so the platform cango get github.com/cdalar/onctl/pkg/cloudand use the provider directly without vendoring or subprocess shelling.Test plan
go build ./...β cleango test ./pkg/cloud/... ./cmd/...β passes