Repository navigation
refactor(hetzner): decouple provider from viper global config - #879
Merged
Merged
Conversation
Add HetznerConfig struct to ProviderHetzner so the provider can be constructed without the viper global singleton. All five config values (location, vm type, image, username, ssh key) are now passed in at construction time from cmd/root.go, making the provider safe for concurrent use in library contexts.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
- Coverage 14.04% 14.01% -0.03%
==========================================
Files 38 38
Lines 3411 3418 +7
==========================================
Hits 479 479
- Misses 2881 2888 +7
Partials 51 51 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HetznerConfigstruct with five fields:Location,VMType,Image,Username,SSHPrivateKeyConfig HetznerConfigfield toProviderHetzner; replace allviper.GetString(...)calls inside the provider with struct field readsviperimport fromhetzner.goentirelyHetznerConfigonce incmd/root.goat provider construction timeMotivation
ProviderHetznerpreviously calledviper.GetString()inline at call sites, coupling it to the global config singleton. This makes the provider unsafe for concurrent use in library contexts (e.g. the plannedonctl-platformSaaS backend, where multiple requests construct providers independently). Config is now injected at construction, so the provider is stateless with respect to global state.Test plan
go build ./...— cleango test ./internal/cloud/...— passesgo run . lswith Hetzner config produces same output as before