Repository navigation
feat: split onctl ls into RUNNING/PAUSED tables for all providers - #873
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 13.98% 13.93% -0.05%
==========================================
Files 38 38
Lines 3411 3422 +11
==========================================
Hits 477 477
- Misses 2882 2893 +11
Partials 52 52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Hetzner already showed two separate tables via ListPaused(). AWS, GCP, and Azure return stopped instances mixed into List() with status values "stopped", "TERMINATED", and "VM deallocated" respectively. Partition those out before rendering so every provider gets the same two-table visual. Closes #872 https://claude.ai/code/session_01GTkvM3QupVmAM7nfRkkdc4
cdalar
force-pushed
the
fix/issue-872-ls-paused-tables
branch
from
June 4, 2026 09:28
ff51fd2 to
27a6d9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #872
ListPaused()(snapshot-based pause). AWS, GCP, and Azure return stopped instances mixed intoList()with provider-specific status strings.isPausedStatus()to detect stopped VMs: AWS"stopped", GCP"TERMINATED"(stopped-not-deleted), Azure"VM deallocated".serverList, any VM whose status matches is moved intopausedListbefore rendering — so the existing two-table display logic now fires for every provider.Test plan
onctl lswith running instances only → single table, no headers (unchanged)onctl lswith a mix of running + stopped AWS instances → green● RUNNING (N)table + yellow● PAUSED (M)tableTERMINATED) and Azure (VM deallocated)onctl ls -o json/-o yaml→ flat combined array, paused VMs present with their original status stringonctl ls -o puppet/-o ansible→ only running instances listed (unchanged)ListPaused()path)https://claude.ai/code/session_01GTkvM3QupVmAM7nfRkkdc4
Generated by Claude Code