Repository navigation
WaitForSSH: say why SSH isn't coming up instead of spinning silently - #1294
Merged
Merged
Conversation
WaitForSSH retried every 100ms until vm.cloud-init.timeout and threw
each error away, so a create whose dial could never succeed looked
hung. On macOS that is what Local Network privacy does to an Apple
container (ac) VM: onctl's Go dial to the vmnet address fails with
EHOSTUNREACH ("no route to host") while /usr/bin/ssh reaches it fine.
- log each distinct dial failure at DEBUG
- include the last error in the timeout message
- on darwin, after 3s of EHOSTUNREACH, print a one-time hint pointing
at System Settings > Privacy & Security > Local Network
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ba6Vc6erd3NJfAyafpSHBj
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
- Coverage 51.28% 51.19% -0.10%
==========================================
Files 86 86
Lines 10165 10191 +26
==========================================
+ Hits 5213 5217 +4
- Misses 4952 4974 +22 β View full report in Codecov by Harness. π New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onctl -p ac createsat afterβ VM IP: β¦until the 3m timeout. The container was up and/usr/bin/sshreached it. But onctl's own Go dial gotconnect: no route to host: macOS Local Network privacy refuses non-Apple binaries on the vmnet LAN.WaitForSSHthrew the error away on every 100ms retry, so it just looked hung.Tested: unit test for
sshWaitHint. Also ran end to end withonctl -p ac createon this Mac. The hint appeared 3s afterVM IP.π€ Generated with Claude Code
https://claude.ai/code/session_01Ba6Vc6erd3NJfAyafpSHBj