Repository navigation
tui: pick a dialog's answer with the arrow keys and enter - #1281
Merged
Merged
Conversation
The y/N questions and the choice popups only took their letter keys; an arrow closed them as a no. Their keys are now buttons: left/right (and tab/shift+tab) move the highlight, enter presses it. The highlight starts on no / cancel, so enter alone still declines, as in destroy's own [y/N]. The letter keys and esc work as before.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
+ Coverage 50.75% 50.85% +0.10%
==========================================
Files 83 83
Lines 9866 9888 +22
==========================================
+ Hits 5007 5029 +22
Misses 4859 4859 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The y/N questions and the choice popups only took their letter keys;
an arrow closed them as a no. Their keys are now buttons: left/right
(and tab/shift+tab) move the highlight, enter presses it. The highlight
starts on no / cancel, so enter alone still declines, as in destroy's
own [y/N]. The letter keys and esc work as before.
Tests:
go test ./cmd/andgolangci-lint run ./cmd/pass. The new test cases fail if the highlight starts on yes.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ba6Vc5qUoi5e5eKonG13ve