Skip to content

release: list every merged PR in the release notes, edge's too - #1272

Merged
cdalar merged 1 commit into
mainfrom
release-notes-list-prs
Oct 27, 2026
Merged

cdalar merged 1 commit into
mainfrom
release-notes-list-prs

Conversation

@cdalar

@cdalar cdalar commented Oct 27, 2026

Copy link
Copy Markdown
Owner

What

Release pages now list every merged PR, the edge release included.

  • Stable releases (.goreleaser.yml): changelog.use: github-native. Each PR is listed with its title, author and link, in two groups from the new .github/release.yml: "Changes", and "Dependency updates" for Dependabot's dependencies label.
  • Starting point (goreleaser.yml workflow): notes count from the last release that was actually published, via GORELEASER_PREVIOUS_TAG, not from the previous tag.
  • Edge release (edge.yml): --generate-notes --notes-start-tag <latest stable>. The existing "unsigned build of main @ sha" line stays above the list, because gh puts --notes text first.

Why

  • The edge release had a fixed one-line body, so the 61 PRs merged since v0.1.35 weren't listed anywhere.
  • The stable notes came from commit subjects counted from the previous tag. When a tag's release failed, its PRs disappeared from every release page:
    • v0.1.34 failed, so its 28 PRs are in no release's notes, and v0.1.35 lists one PR.
    • v0.1.32 also failed, so v0.1.33 lists one commit.

Testing

  • goreleaser check validates .goreleaser.yml.
  • A dry run of gh api repos/cdalar/onctl/releases/generate-notes from v0.1.35 to main returns all 61 PRs, which is what edge will now show.
  • actionlint reports nothing new. It only flags the custom onctl-2 runner label and a shellcheck note in the existing GPG step.
  • The edge workflow is first exercised for real when this merges. A stable release is exercised at the next tag.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ba6Vc6KwaV9dTWbzYVKA78

Releases now use GitHub's generated notes (each PR's title, author and
link), grouped by .github/release.yml, counted from the last release
that was actually published -- a tag whose release failed (v0.1.34)
took its 28 PRs out of every release's notes. The edge release lists
the PRs merged since the latest stable one, under its build line.
@cdalar
cdalar merged commit 03ec3ca into main Oct 27, 2026
12 checks passed
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.11%. Comparing base (952fec9) to head (05829b0).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1272   +/-   ##
=======================================
  Coverage   50.11%   50.11%           
=======================================
  Files          83       83           
  Lines        9761     9761           
=======================================
  Hits         4892     4892           
  Misses       4869     4869           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址