Repository navigation
tui: a created VM is shown in :vms, under the cursor - #1271
Merged
Merged
Conversation
After onctl create succeeds the tui goes to :vms with the new VM selected and the state filter off, wherever create was asked from (:images, :sizes). A failed create stays where it was.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
==========================================
+ Coverage 50.11% 50.14% +0.02%
==========================================
Files 83 83
Lines 9761 9764 +3
==========================================
+ Hits 4892 4896 +4
+ Misses 4869 4868 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After a VM is created from the TUI, it opens
:vmswith the new VM under the cursor. This applies wherever create was started::images,:sizesor:vms. The state filter (0/1/2) and the/filter are cleared so neither hides the new VM. A failed create leaves you on the page you were on.Testing
TestTUICreateGoesToVMs: a create from:imageswith the paused-only filter on lands on:vmswith the new VM selected. A failed create stays on:images. The test fails without the change.go test ./...passes, andgolangci-lintis clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ba6Vc6KwaV9dTWbzYVKA78