Skip to content

tui: space marks VMs in :vms, and ctrl-d destroys the marked ones - #1269

Merged
cdalar merged 1 commit into
mainfrom
tui-multi-select
Oct 27, 2026
Merged

cdalar merged 1 commit into
mainfrom
tui-multi-select

Conversation

@cdalar

@cdalar cdalar commented Oct 27, 2026

Copy link
Copy Markdown
Owner

What

In :vms, space marks the VM under the cursor (again: unmarks it) and moves down. A marked row starts with *. ctrl-d with marks asks once, listing every marked VM, then destroys each. n keeps the marks, and y clears them. With nothing marked, ctrl-d destroys the VM under the cursor as before. On a describe page it's still only that VM.

A marked VM that's already busy (being paused, say) is refused as a single destroy would be, and the rest still go.

Testing

  • TestTUIDestroyMarked marks two VMs and toggles a third off. It checks the dialog names both, n changes nothing, and y destroys exactly those two and clears the marks.
  • Mutation check: destroying only the first marked VM fails the test.
  • go test ./... passes, and golangci-lint is clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ba6Vc6KwaV9dTWbzYVKA78

One confirmation lists every marked VM; n keeps the marks, y destroys
each and clears them. With nothing marked, ctrl-d destroys the VM under
the cursor, as before.
@cdalar
cdalar merged commit edcc06c into main Oct 27, 2026
12 checks passed
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.91%. Comparing base (0027c86) to head (2aef31f).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/tuiactions.go 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
+ Coverage   49.75%   49.91%   +0.16%     
==========================================
  Files          83       83              
  Lines        9706     9742      +36     
==========================================
+ Hits         4829     4863      +34     
- Misses       4877     4879       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址