Repository navigation
tui: space marks VMs in :vms, and ctrl-d destroys the marked ones - #1269
Merged
Merged
Conversation
One confirmation lists every marked VM; n keeps the marks, y destroys each and clears them. With nothing marked, ctrl-d destroys the VM under the cursor, as before.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
==========================================
+ Coverage 49.75% 49.91% +0.16%
==========================================
Files 83 83
Lines 9706 9742 +36
==========================================
+ Hits 4829 4863 +34
- Misses 4877 4879 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
:vms,spacemarks the VM under the cursor (again: unmarks it) and moves down. A marked row starts with*.ctrl-dwith marks asks once, listing every marked VM, then destroys each.nkeeps the marks, andyclears them. With nothing marked,ctrl-ddestroys the VM under the cursor as before. On a describe page it's still only that VM.A marked VM that's already busy (being paused, say) is refused as a single destroy would be, and the rest still go.
Testing
TestTUIDestroyMarkedmarks two VMs and toggles a third off. It checks the dialog names both,nchanges nothing, andydestroys exactly those two and clears the marks.go test ./...passes, andgolangci-lintis clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ba6Vc6KwaV9dTWbzYVKA78