Repository navigation
ssh: give the VM's shell TERM=xterm-256color - #1268
Merged
Merged
Conversation
The VM has no terminfo for xterm-ghostty (or xterm-kitty), so tmux refused to start in an onctl ssh shell from Ghostty. onctl claude's attach already sets TERM this way.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
+ Coverage 49.75% 49.92% +0.17%
==========================================
Files 83 83
Lines 9706 9708 +2
==========================================
+ Hits 4829 4847 +18
+ Misses 4877 4861 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
onctl ssh(and the TUI's ssh action) now runs ssh withTERM=xterm-256color, asonctl claude's attach already does (cmd/claude.go:853).Why
From Ghostty,
tmux aon a box failed withmissing or unsuitable terminal: xterm-ghostty: the image has no terminfo for it.Testing
TestSSHIntoVM_UsesACommonTERMruns a fakesshwithTERM=xterm-ghosttyset; it fails without the change.go test ./...passes andgolangci-lintis clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ba6Vc6KwaV9dTWbzYVKA78