Repository navigation
tui: ask for the provider when neither -p nor ONCTL_CLOUD is set - #1261
Merged
Merged
Conversation
onctl tui starts with a list of the providers, each with its full name and where it runs (local, cloud with your own account, cloud SaaS, or a host you bring), instead of guessing one from the credentials in the environment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
- Coverage 47.99% 47.99% -0.01%
==========================================
Files 81 81
Lines 9401 9424 +23
==========================================
+ Hits 4512 4523 +11
- Misses 4889 4901 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onctl tuiwith no-pand noONCTL_CLOUDnow starts by asking which provider to work on. Each line shows the short name, the full name, and where the machines run:-p <name>, so loading the config and starting the provider work as before. If stdin isn't a terminal there's no prompt and the old behaviour applies.providerPlacesgets atitle(the provider's own name) and a newplaceSaaSkind for boxes.providerWherestill says "on the boxes service".HCLOUD_TOKENmeant hetzner). Now it asks. Other commands are unchanged.Testing
TestTUIProviderChoiceschecks that every provider has a full name in the list and that each kind gets the right label.go vet ./cmdpasses.go test ./cmdpasses exceptTestPopulateOnctlEnv_ErrorWritingFile, which also fails onmainwhen run as root (the sandbox this was tested in runs as root).🤖 Generated with Claude Code