Skip to content

ac: show a progress bar while pulling an image - #1259

Merged
cdalar merged 1 commit into
mainfrom
onctl/witty-willow-4986
Oct 26, 2026
Merged

cdalar merged 1 commit into
mainfrom
onctl/witty-willow-4986

Conversation

@cdalar

@cdalar cdalar commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • `onctl -p ac claude` pulled the image with stderr captured, so a first run showed only "Pulling ..." and then nothing.
  • Adds an optional `ACStreamer` interface; the CLI runner implements `Stream`, which attaches the `container` CLI's output to the terminal. `Deploy` uses it for `image pull`, falling back to `Run` for runners without it (test fakes).

Not verified

  • Not compiled or tested: Go and the `container` CLI were unavailable where this was written. Please run `go build ./... && go test ./pkg/cloud ./internal/providerac`.
  • Assumes `container image pull` draws its own progress bar on a terminal; try `onctl -p ac claude` after `container image rm ghcr.io/boxctl-io/claude-agent:latest`.
  • No test added for `Stream` (it only shells out to a terminal).

🤖 Generated with Claude Code

The pull ran with stderr captured, so a first onctl claude on ac sat
silent for hundreds of MB. Runners that can stream (ACStreamer) now put
the pull's output on the terminal.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.99%. Comparing base (e4701ad) to head (43861aa).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/providerac/common.go 0.00% 6 Missing ⚠️
pkg/cloud/ac.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
- Coverage   48.01%   47.99%   -0.02%     
==========================================
  Files          81       81              
  Lines        9391     9401      +10     
==========================================
+ Hits         4509     4512       +3     
- Misses       4882     4889       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdalar
cdalar merged commit e06bcd5 into main Oct 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址