Repository navigation
ac: say when the sandbox's image is being pulled - #1237
Merged
Merged
Conversation
`container run` pulls a missing image itself, but silently, and a first pull of ghcr.io/boxctl-io/claude-agent is over 600 MB: `onctl -p ac claude` sat on "Creating ... on ac" with nothing to show for a minute. Deploy now asks `container image inspect` first and, when the image isn't on the Mac, prints "Pulling <image>..." and runs `container image pull` before `run`; a pull that fails is reported as such rather than as a failed run. onctl create goes through the same Deploy. Claude-Session: https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
+ Coverage 47.49% 47.51% +0.02%
==========================================
Files 80 80
Lines 9326 9330 +4
==========================================
+ Hits 4429 4433 +4
Misses 4897 4897 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
container runpulls a missing image itself, but silently, and a first pull ofghcr.io/boxctl-io/claude-agentis over 600 MB:onctl -p ac claudesat on "Creating ... on ac" with nothing to show for a minute.Deploynow askscontainer image inspectfirst and, when the image isn't on the Mac, printsPulling <image>...and runscontainer image pullbeforerun. A pull that fails is reported as such rather than as a failed run.onctl creategoes through the sameDeploy.Test:
TestAC_Deploy_PullsMissingImagecovers inspect-then-pull on a missing image, no pull when present, and the error on a failed pull with norunattempted.🤖 Generated with Claude Code
https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR