Skip to content

chore: remove stale scripts/deploy-controller.sh - #1229

Merged
cdalar merged 1 commit into
mainfrom
chore/remove-deploy-controller-script
Oct 23, 2026
Merged

cdalar merged 1 commit into
mainfrom
chore/remove-deploy-controller-script

Conversation

@cdalar

@cdalar cdalar commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • Delete scripts/deploy-controller.sh. Nothing in this repo or in cdalar/onctl-runners references it.

Why

  • The script installed /usr/local/bin/onctl on the controller VM for the old plain-binary + systemd deployment. That topology is gone from onctl-runners; the controller now runs as a Docker container on the control-plane VM, and the image installs its own onctl from the edge channel.
  • Deploys are automated: onctl-runners' build-controller-image workflow publishes the image on push to main, and deploy-controller.yml then runs update-control-plane.sh via workflow_run.
  • The VM was renamed from onctl-controller to control-plane on 2026-09-20, so the script's onctl ssh onctl-controller upload step would fail regardless.

Test plan

  • grep -rn deploy-controller in this repo returns nothing after the change (verified locally).
  • CI passes (no code paths touched).

🤖 Generated with Claude Code

The script replaced /usr/local/bin/onctl on the controller VM for the old
plain-binary + systemd deployment. That setup is gone: the controller now
runs as a Docker container on the control-plane VM and is deployed by
cdalar/onctl-runners' deploy-controller workflow, and the image installs
its own onctl from the edge channel. The VM was also renamed from
onctl-controller to control-plane on 2026-09-20, so the upload step would
fail anyway. Nothing references the script.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.74%. Comparing base (1e0fc6a) to head (2693670).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1229   +/-   ##
=======================================
  Coverage   46.74%   46.74%           
=======================================
  Files          75       75           
  Lines        8786     8786           
=======================================
  Hits         4107     4107           
  Misses       4679     4679           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdalar
cdalar merged commit eff7bea into main Oct 23, 2026
13 checks passed
@cdalar
cdalar deleted the chore/remove-deploy-controller-script branch October 23, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址