Repository navigation
chore: remove stale scripts/deploy-controller.sh - #1229
Merged
Merged
Conversation
The script replaced /usr/local/bin/onctl on the controller VM for the old plain-binary + systemd deployment. That setup is gone: the controller now runs as a Docker container on the control-plane VM and is deployed by cdalar/onctl-runners' deploy-controller workflow, and the image installs its own onctl from the edge channel. The VM was also renamed from onctl-controller to control-plane on 2026-09-20, so the upload step would fail anyway. Nothing references the script. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
=======================================
Coverage 46.74% 46.74%
=======================================
Files 75 75
Lines 8786 8786
=======================================
Hits 4107 4107
Misses 4679 4679 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/deploy-controller.sh. Nothing in this repo or incdalar/onctl-runnersreferences it.Why
/usr/local/bin/onctlon the controller VM for the old plain-binary + systemd deployment. That topology is gone from onctl-runners; the controller now runs as a Docker container on the control-plane VM, and the image installs its own onctl from the edge channel.build-controller-imageworkflow publishes the image on push to main, anddeploy-controller.ymlthen runsupdate-control-plane.shviaworkflow_run.onctl-controllertocontrol-planeon 2026-09-20, so the script'sonctl ssh onctl-controllerupload step would fail regardless.Test plan
grep -rn deploy-controllerin this repo returns nothing after the change (verified locally).🤖 Generated with Claude Code