[cdalar]

Problem

onctl -p ac delete <TAB> did not complete VM names. Cobra's completion path (__complete) parses flags but skips PersistentPreRunE, which was the only place -p/--provider was copied into ONCTL_CLOUD. So ensureProvider resolved the provider from the environment instead:

• ONCTL_CLOUD unset: exits with "No Cloud Provider Set", no completions.
• ONCTL_CLOUD set to another provider: completes that provider's VM names.

Exporting ONCTL_CLOUD=ac always worked, which made it look ac-specific.

Fix

Move the -p validation and ONCTL_CLOUD assignment into applyProviderFlag, called from both PersistentPreRunE and ensureProvider. This covers every completion that lists VMs or sizes: destroy and its aliases, ssh, port-forward, images, and the --type/--size size completions.

Verification

• New TestEnsureProvider_HonorsProviderFlag: ONCTL_CLOUD=static with providerFlag = "ac" must build the ac provider. Fails on the old code, passes now.
• End to end with a fake container CLI: onctl -p ac __complete delete "" returns the ac VM names with ONCTL_CLOUD unset and with it set to static; -p bogus returns the error directive.
• go test ./cmd/ passes (one pre-existing, unrelated failure when run as root: TestPopulateOnctlEnv_ErrorWritingFile expects a read-only dir write to fail).

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.70%. Comparing base (e171e43) to head (e002edf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/root.go	60.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   45.57%   45.70%   +0.12%     
==========================================
  Files          75       75              
  Lines        8778     8783       +5     
==========================================
+ Hits         4001     4014      +13     
+ Misses       4777     4769       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.