Repository navigation
claude: honor ONCTL_CLOUD, don't force boxes when -p is absent - #1214
Merged
Merged
Conversation
onctl claude defaulted to boxes whenever -p wasn't given, overriding ONCTL_CLOUD: `ONCTL_CLOUD=ac onctl claude` created a hosted box on the boxes service instead of an Apple container on this machine. The boxes default now applies only when neither -p nor ONCTL_CLOUD picks a provider, as for every other command. Claude-Session: https://claude.ai/code/session_01SB788HixFrKbYGCxDRi8fX
cdalar
enabled auto-merge (squash)
October 22, 2026 04:39
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
+ Coverage 45.22% 45.24% +0.01%
==========================================
Files 75 75
Lines 8732 8735 +3
==========================================
+ Hits 3949 3952 +3
Misses 4782 4782
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ONCTL_CLOUD=ac onctl claudecreated a hosted box on the boxes service, not an Apple container on this machine. The claude command set the provider to boxes whenever-pwas absent, without looking atONCTL_CLOUD.What
The boxes default now applies only when neither
-pnorONCTL_CLOUDpicks a provider.-pstill wins over the env var, as for every other command. Pulled into a smallclaudeProviderfunction with a table test that spells out the intent.Verified
ONCTL_CLOUD=ac onctl claude --detachprinted "Creating claude-onctl (claude-agent, medium)" and a box appeared inonctl -p boxes ls;container lsunchanged.container lsshowsclaude-onctlrunning with aclaudetmux session and the project at/Users/cd/cdalar/onctl.go test ./cmd/passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01SB788HixFrKbYGCxDRi8fX