Repository navigation
Install shell completion from get.sh and get-edge.sh - #1189
Merged
Merged
Conversation
The install scripts now generate tab completion for the user's login shell (bash, zsh, fish) with the binary they just downloaded, the same way boxctl.io/get.sh does. ONCTL_NO_COMPLETION=1 skips it. onctl completion <shell> no longer requires an initialized .onctl directory, since the installer runs it before onctl init. Binaries released before this change print nothing there, so the scripts treat an empty script as a failure and skip with a warning. Claude-Session: https://claude.ai/code/session_01VHSGn6gnEQjsKxg2QaHxD7
cdalar
enabled auto-merge (squash)
October 9, 2026 16:02
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1189 +/- ##
==========================================
+ Coverage 39.66% 39.83% +0.16%
==========================================
Files 67 67
Lines 7296 7298 +2
==========================================
+ Hits 2894 2907 +13
+ Misses 4402 4391 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
onctl.sh/get.shandget-edge.shnow set up tab completion for the login shell (bash, zsh or fish), ported fromboxctl.io/get.sh. They write the script to the per-user completion directory and, for bash and zsh, add one guarded line to~/.bashrc/~/.zshrc.ONCTL_NO_COMPLETION=1skips it.onctl completion <shell>no longer needs an initialized.onctldirectory. Before this, it printed nothing and exited 0 on a fresh machine, which is exactly when the installer runs.Note on rollout
The tagged release that
get.shdownloads today still has the old behaviour, so until the next releaseget.shprints "could not generate completion; skipping" and installs the binary as before.get-edge.shpicks up the fix as soon as this merges.Testing
get-edge.shin throwawayHOMEs for zsh, bash and fish against a binary built from this branch: script written, rc line added once across two runs,compdef/complete -pshow onctl registered.node_modules).🤖 Generated with Claude Code
https://claude.ai/code/session_01VHSGn6gnEQjsKxg2QaHxD7