Repository navigation
test: improve coverage for templates, azure id resolution and apply dirs - #1178
Merged
Merged
Conversation
Adds tests for findSingleFile's embedded-file branch, resolveAzureIdentifiers (using a fake az on PATH), ensureProvider, checkCloudProvider and tools.NextApplyDir. Total statement coverage 52.9% -> 53.9%. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
cdalar
enabled auto-merge (squash)
October 5, 2026 05:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findSingleFile(embedded-file branch, local file overrides embedded),findFile,resolveAzureIdentifiers,ensureProviderandcheckCloudProviderincmd/logic_coverage_test.go.tools.NextApplyDirtests ininternal/tools/apply_dir_test.go.azonPATH, so they need no real login.internal/tools39.8% -> 47.8%;cmd45.7% -> 46.0%).Test plan
go test ./...passes,go vet,gofmtandgolangci-lintclean (Go 1.27.1)TestPopulateOnctlEnv_ErrorWritingFilefails when run as root (root ignores the0444permission it relies on) and panics thecmdpackage. I skipped it locally with-skip; it is unchanged and unrelated to this PR.Remaining gaps are mostly cloud-SDK wrappers (
deploy.go,hetzner.go,aws.go,azure.go) and theproviderch/providerfcshell-out code, which need fakes or refactoring.🤖 Generated with Claude Code