Repository navigation
Remove the onctl vm command group - #1172
Merged
Merged
Conversation
It only re-registered create, destroy, ls, ssh, pause, resume and restart, which already exist at the root. Because cobra keeps one parent per command, it also made 'onctl create --help' print 'onctl vm create' as the usage path.
cdalar
enabled auto-merge (squash)
October 4, 2026 21:56
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
- Coverage 39.83% 39.75% -0.08%
==========================================
Files 61 60 -1
Lines 6384 6376 -8
==========================================
- Hits 2543 2535 -8
Misses 3841 3841 β View full report in Codecov by Harness. π New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
onctl vm, a command group that only re-registeredcreate,destroy,ls,ssh,pause,resumeandrestartβ all of which already exist at the root.Why
vmregistration won:onctl create --helpprintedUsage: onctl vm create [flags](same for the other six). It now printsonctl create [flags].port-forward,images,deploy,action,importwere root-only).Breaking
onctl vm <cmd>no longer works; useonctl <cmd>.Testing
go build ./...,go vet ./cmd/pass.go test ./...passes exceptTestReadConfig_NoConfigDirectoryandTestCreateFlagsBindToViper, which fail identically onmainon my machine because they pick up the real~/.onctlconfig.π€ Generated with Claude Code
https://claude.ai/code/session_018VbxXEmRHo64NuJUPsyMuW