Repository navigation
Add onctl sizes: the VM sizes --type takes, per provider - #1170
Merged
Merged
Conversation
A SizeLister optional interface, like ImageLister, implemented for: - boxes: /api/sizes (small/medium/large, the service's default marked) - Hetzner: server types offered in the configured location, with that location's hourly and monthly prices; deprecated types and types not available there are left out. Prices are in EUR (server-type prices carry no currency; the cost column in ls makes the same assumption). - OVH: flavors available in the configured region (no prices: the API publishes none). Smallest first, the configured default marked with *, and columns no size fills in are left out. fc/ch say they take --vcpu/--memory instead. create's --type completes from the same list. AWS, GCP and Azure follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U8g3mHkS6JmtYVYc4AjcV4
cdalar
enabled auto-merge (squash)
October 4, 2026 21:48
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1170 +/- ##
==========================================
+ Coverage 39.09% 39.83% +0.74%
==========================================
Files 59 61 +2
Lines 6244 6384 +140
==========================================
+ Hits 2441 2543 +102
- Misses 3803 3841 +38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onctl sizeslists what--typeaccepts for the current provider. It's a new optionalSizeListerinterface, likeImageLister. This PR covers boxes, Hetzner and OVH; AWS, GCP and Azure come next, since they need region handling and filtering.Per provider
GET /api/sizes; the service's default is marked./pricingdoes), andls's cost column makes the same assumption.--vcpu/--memory, since these providers have no fixed sizes.Output
*.onctl create --type <TAB>completes from the same list.Tests
/api/sizes.go test -race -shuffle=on ./...and golangci-lint are clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01U8g3mHkS6JmtYVYc4AjcV4