Repository navigation
ci: run build and lint on docs-only changes; fix the order-dependent flags test - #1158
Conversation
Both are required checks on main, but skipped any change confined to docs/**, so a docs-only pull request could never satisfy branch protection and stayed blocked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U8g3mHkS6JmtYVYc4AjcV4
|
No fix exists yet, and I'm not widening this PR to touch the test. I've re-run the failed job once. If it fails again, the test needs fixing on Generated by Claude Code |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
=======================================
Coverage 36.89% 36.89%
=======================================
Files 51 51
Lines 5656 5656
=======================================
Hits 2087 2087
Misses 3569 3569 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Two fixes that keep docs-only PRs (and
main) from being stuck.1. Required checks on docs-only changes.
Build (stable)andLintare required onmain, but both workflows hadpaths-ignore: docs/**. A docs-only PR therefore never got those checks and stayed blocked by branch protection; #1157 is stuck that way now. This PR removes the filter frombuild.ymlandlint.yml.2.
main's build has been red since 2026-10-02, from an order-dependent test.withViper, incmd/root_provider_test.go, restored a key withviper.Set(key, orig). That leaves a permanent override in viper's highest-priority layer.-shuffle=on, when a root_provider test runs beforeTestCreateFlagsBindToViper,--fc-binarycan no longer changefc.binPath, and the test fails.viper.Set(key, nil). Viper skips a nil override and falls through to flags, config and defaults.HOME(as on CI) with-shuffleseeds 1–12; seeds 3 and 6 failed before the fix and pass now. The fullgo test -race -shuffle=on ./...is clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01U8g3mHkS6JmtYVYc4AjcV4