Repository navigation
Report each fc/ch VM's base image as Vm.BaseImage - #1141
Merged
Merged
Conversation
fc already stored BaseImagePath, but only when hashing the base image succeeded; it's now always recorded (export still keys off the SHA). ch now records it too. Both surface it as Vm.BaseImage, so `onctl ls -o json` says which base image a VM was cloned from -- Image is the VM's own per-VM copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jek343oi27jMbwBi9depxo
cdalar
force-pushed
the
record-base-image
branch
from
September 27, 2026 16:08
5f848f0 to
a25d63d
Compare
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
+ Coverage 34.54% 34.56% +0.02%
==========================================
Files 51 51
Lines 5610 5612 +2
==========================================
+ Hits 1938 1940 +2
Misses 3672 3672 β View full report in Codecov by Harness. π New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseImagePathat Deploy (it was only set when hashing the base image succeeded). Diff export still keys offBaseImageSHA256, so an unhashed path is never diffed against.BaseImagePathtoo.Vm.BaseImage, soonctl ls -o jsonsays which base image a VM was cloned from (Imageis the VM's own per-VM copy).Needed by boxctl-vms to return each box's image name (
boxctl lsIMAGE column).Test plan
go test ./pkg/cloud/(updated the identity-failure test: path is now recorded, SHA still empty)go test ./cmd/has two failures (TestReadConfig_NoConfigDirectory,TestCreateFlagsBindToViper) that also fail onmainlocally β not from this changeπ€ Generated with Claude Code
https://claude.ai/code/session_01Jek343oi27jMbwBi9depxo