Skip to content

Report each fc/ch VM's base image as Vm.BaseImage - #1141

Merged
cdalar merged 1 commit into
mainfrom
record-base-image
Sep 27, 2026
Merged

cdalar merged 1 commit into
mainfrom
record-base-image

Conversation

@cdalar

@cdalar cdalar commented Sep 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • fc: always record BaseImagePath at Deploy (it was only set when hashing the base image succeeded). Diff export still keys off BaseImageSHA256, so an unhashed path is never diffed against.
  • ch: record BaseImagePath too.
  • Both surface it as Vm.BaseImage, so onctl ls -o json says which base image a VM was cloned from (Image is the VM's own per-VM copy).

Needed by boxctl-vms to return each box's image name (boxctl ls IMAGE column).

Test plan

  • go test ./pkg/cloud/ (updated the identity-failure test: path is now recorded, SHA still empty)
  • go test ./cmd/ has two failures (TestReadConfig_NoConfigDirectory, TestCreateFlagsBindToViper) that also fail on main locally β€” not from this change

πŸ€– Generated with Claude Code

https://claude.ai/code/session_01Jek343oi27jMbwBi9depxo

fc already stored BaseImagePath, but only when hashing the base image
succeeded; it's now always recorded (export still keys off the SHA). ch
now records it too. Both surface it as Vm.BaseImage, so `onctl ls -o
json` says which base image a VM was cloned from -- Image is the VM's
own per-VM copy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jek343oi27jMbwBi9depxo
@codecov

codecov Bot commented Sep 27, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 34.56%. Comparing base (0e0c6de) to head (a25d63d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
+ Coverage   34.54%   34.56%   +0.02%     
==========================================
  Files          51       51              
  Lines        5610     5612       +2     
==========================================
+ Hits         1938     1940       +2     
  Misses       3672     3672              

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdalar
cdalar merged commit 4f2cb2c into main Sep 27, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 捒网址