Repository navigation
Skip the SSHReady TCP probe for fc (Firecracker boots too fast to need it) - #1108
Merged
Merged
Conversation
Reported live as unnecessary added latency: fc's List() was probing every not-yet-confirmed VM's SSH port the same way ch's now does, but a Firecracker microVM boots in milliseconds (the whole point of the technology) -- by the time any caller sees it in List() at all, Status=="running" is already an accurate-enough proxy for "the guest is reachable." Probing anyway only added needless latency to every List() call (and, via boxctl-vms-agent.sh's periodic poll, to every dashboard refresh) for a distinction that isn't real for this provider. fc's Vm.SSHReady is now derived straight from Status (mapFCVM) instead of a real probe -- ch (a genuinely slow-booting Windows guest) keeps the real TCP probe from #1105 unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012iVNj3mykz8m7QfuxWN3ae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vm.SSHReadyto bothfcandch'sList().fcside, where the whole "still booting" gap this exists for basically doesn't happen -- a Firecracker microVM boots in milliseconds.fc'sList()no longer probes at all;Vm.SSHReadyis derived straight fromStatusinmapFCVMinstead.ch(Cloud Hypervisor/Windows, where boots genuinely can take minutes) is unchanged -- still does the real probe from Add a real SSH-reachability signal to fc/ch's List() #1105.Test plan
go build ./...,go vet ./pkg/cloud/...,gofmt -lclean,go test ./pkg/cloud/...passesTestProviderFC_List_SSHReadyMirrorsStatus) deploys a VM with no real reachable IP and confirmsList()still reportsSSHReady: true-- proving the probe path is actually gone, not just untested🤖 Generated with Claude Code