Repository navigation
fix(edge): resolve OOM on onctl-4 runner, drop unused Windows target - #1094
Merged
Merged
Conversation
e624e38 moved this workflow from ubuntu-latest onto the self-hosted onctl-4 runner. GoReleaser builds all 3 targets (windows/amd64, linux/arm64, linux/amd64) in parallel by default, and compiling aws-sdk-go-v2/service/ec2 three times at once OOM-killed the compiler on that box (signal: killed, confirmed in run 34082530839). --parallelism=1 serializes the builds, capping peak memory to one target at a time. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lx5i19SzjoDPrn1eccMzCe
Nothing currently consumes the edge Windows binary, and dropping it is a second, independent way to cut peak memory on the resource-constrained onctl-4 runner (one less target for GoReleaser to build, on top of the --parallelism=1 serialization already applied). Updates get_edge.sh (drops the Windows branch, mirroring the existing macOS "not published" error) and the README/docs Edge build sections to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lx5i19SzjoDPrn1eccMzCe
No more Windows target means no more .zip archives; gh release create rejected the literal unmatched glob (no matches found for \`dist/*.zip\`), confirmed live in run 34084368621. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lx5i19SzjoDPrn1eccMzCe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edgeworkflow started failing after #e624e38 moved it fromubuntu-latestonto the self-hostedonctl-4runner: GoReleaser builds all targets in parallel by default, and compilingaws-sdk-go-v2/service/ec2three times at once (windows/amd64, linux/arm64, linux/amd64) OOM-killed the compiler on that box (confirmed live in run 34082530839:signal: killed).--parallelism=1to the goreleaser invocation inedge.yml, serializing the target builds to cap peak memory to one target at a time..goreleaser.edge.yml(nothing currently consumes the edge Windows binary), a second independent way to reduce load on the constrained runner. Updatesget_edge.shand the README/docs "Edge build" sections to match (Linux only now), and drops the now-emptydist/*.zipglob from the release-publish step.Test plan
goreleaser check -f .goreleaser.edge.ymlβ config validatesbash -n docs/static/get_edge.shβ syntax checkedge.ymlon this branch 3 times to iterate live against the actualonctl-4runner (not guessable from a local machine): (1)--parallelism=1alone β succeeded, confirming the root cause; (2) + dropped Windows β build succeeded, release-publish failed on the now-emptydist/*.zipglob; (3) + glob fix β fully succeedededgerelease now has exactlyonctl-linux-amd64.tar.gz,onctl-linux-arm64.tar.gz,checksums.txt(no Windows asset)π€ Generated with Claude Code
https://claude.ai/code/session_01Lx5i19SzjoDPrn1eccMzCe