Repository navigation
Rename nightly build to edge, harden tag exclusion - #1088
Merged
Merged
Conversation
…g tag "nightly" implied a schedule this build doesn't have (it fires on every push to main, not on a timer) -- "edge" matches Alpine Linux's own term for exactly this (a continuously-updated rolling branch) and Docker's :edge tag convention, without the schedule connotation. Also generalizes the previous fix (exclude the rolling tag from GoReleaser's version discovery) from hardcoding one tag name to deleting any tag that isn't vX.Y.Z-shaped. Found live while testing the rename: deleting only the new `edge` tag locally still failed, because the old `nightly` tag (this pipeline's previous name) was still on the remote, got fetched, and was even closer to HEAD -- a rolling tag always points near HEAD by construction, which is exactly what makes GoReleaser prefer it over the real, further-back semver tags. The general filter means this survives any future rename or any other non-semver tag in the repo, rather than needing another fix the next time the name changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F75TsjPk2tV2RD1rizu6eF
![chatgpt-codex-connector[bot]](/p/https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f8a0786a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The previous pattern (^v[0-9]+\.[0-9]+\.[0-9]+, unanchored at the end) would still keep -- and thus still risk breaking the build on -- a tag like v1.2.3foo or v0.1.33-edge, since it only checked the prefix. Reproduced live: `v0.1.33-edge` matched the old pattern (wrongly kept) and doesn't match the fixed one (correctly excluded), while real tags like `v0.1.33` still match either way. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F75TsjPk2tV2RD1rizu6eF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:edgetag convention. "Nightly" implied a schedule this build doesn't have; it fires on every push tomain, not on a timer..goreleaser.nightly.yml→.goreleaser.edge.yml,.github/workflows/nightly.yml→.github/workflows/edge.yml, tag/release renamednightly→edgethroughout.git tag -d nightly) into deleting any non-vX.Y.Ztag, not one hardcoded name. Found live while testing this rename: deleting only the newedgetag locally still failed the build, because the oldnightlytag (this pipeline's previous name, already published to the remote) was still fetched and was even closer to HEAD thanedge— a rolling tag always sits near HEAD by construction, which is exactly what makes GoReleaser's version discovery prefer it over the real, further-back semver tags. The general filter survives this pipeline being renamed again later, or any other non-semver tag existing in the repo (this repo already has a few unrelated ones:dev,legacy-cloud-engine,spike/gh-runner-phase2).Test plan
dev,edge,legacy-cloud-engine,nightly,spike/gh-runner-phase2) and confirmed the filter strips all of them, leaving only real semver tags, and the build succeedsnightlyrelease/tag from the repo after this merges (superseded byedge), and confirm the first realedgerun publishes correctly🤖 Generated with Claude Code
https://claude.ai/code/session_01F75TsjPk2tV2RD1rizu6eF