Skip to content

ci: remove Claude Code Review workflow - #1079

Merged
cdalar merged 2 commits into
mainfrom
ci/remove-claude-code-review
Sep 3, 2026
Merged

cdalar merged 2 commits into
mainfrom
ci/remove-claude-code-review

Conversation

@cdalar

@cdalar cdalar commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • The claude-code-review.yml workflow fails on every run before it even reads the diff: Failed to add marketplace: Failed to clone marketplace repository: HTTPS authentication failed cloning anthropics/claude-code.git on the self-hosted onctl-4 runner.
  • This is an infra/auth issue in the workflow's own setup, not something re-running fixes, and it's been failing consistently across unrelated PRs (see fix(fc): reflink-copy base rootfs image instead of full byte copy #1076).
  • Removes the workflow entirely rather than leaving a perpetually-red, non-actionable check on every PR.

Test plan

  • N/A — workflow file removal only, no code changes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PVpF4aLeq6xpokgHiBCy4v

Every run fails before it even reads the diff — "Failed to add
marketplace: Failed to clone marketplace repository: HTTPS
authentication failed" cloning anthropics/claude-code.git on the
self-hosted onctl-4 runner — an infra/auth issue with the workflow
itself, unrelated to any PR's content. Re-running doesn't help since
it's not transient.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PVpF4aLeq6xpokgHiBCy4v

cdalar commented Sep 3, 2026

Copy link
Copy Markdown
Owner Author

The Vuln check (govulncheck) is failing, but it's not caused by this PR — this PR only removes claude-code-review.yml, it doesn't touch go.mod/go.sum.

The failure is a pre-existing finding:

  • GO-2026-6355 / GO-2026-6354: DoS on deadlocked SSH channel in golang.org/x/crypto/ssh
  • Found in golang.org/x/crypto@v0.55.0 (fixed in v0.56.0)
  • Reached via internal/tools/remote-run.go:108 → ssh.Dial

main's go.mod also pins golang.org/x/crypto v0.55.0, so this same check would fail on main today too. No dependency-bump PR for this exists yet (dependabot hasn't opened one), so there's nothing to port into this PR.

Proposed fix (separate from this PR, since it's unrelated to the workflow removal): bump golang.org/x/crypto to v0.56.0 via go get golang.org/x/crypto@v0.56.0 && go mod tidy.

I'll continue watching this PR; it's otherwise ready to merge once other checks complete.


Generated by Claude Code

cdalar commented Sep 3, 2026

Copy link
Copy Markdown
Owner Author

The claude-review check on this PR's own run is also failing (same marketplace-clone auth error described in the PR body). That's expected and can't be fixed by pushing to this branch: the workflow is triggered by pull_request_target, so GitHub resolves and runs the workflow definition from main (where the file still exists) regardless of what this PR's diff does to it. Merging this PR is what stops it — future PRs won't trigger this workflow anymore, since it'll be gone from main.

Confirmed via #1078 (merged earlier today) that neither claude-review nor Vuln are required status checks, so they shouldn't block this PR either.


Generated by Claude Code

@cdalar
cdalar merged commit 1a10e5a into main Sep 3, 2026
11 of 13 checks passed
@cdalar
cdalar deleted the ci/remove-claude-code-review branch September 3, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址