Skip to content

feat(fc): support bridge/cidr format in fc.network.bridge - #1062

Merged
cdalar merged 1 commit into
mainfrom
ai/fix-bridge-customization
Aug 29, 2026
Merged

cdalar merged 1 commit into
mainfrom
ai/fix-bridge-customization

Conversation

@cdalar

@cdalar cdalar commented Aug 29, 2026

Copy link
Copy Markdown
Owner

This PR adds support for specifying both the bridge name and the CIDR in a single string using the bridge/cidr format for the fc.network.bridge configuration option.

This addresses an issue where the custom bridge and CIDR configuration was being ignored in certain builds.

Testing:

  • Verified that fc.network.bridge can now be set to mybr0/10.0.0.1/24.
  • Verified that existing functionality (setting bridge and CIDR separately) still works.
  • Ran go test ./internal/providerfc/... and all tests passed.

cdalar commented Aug 29, 2026

Copy link
Copy Markdown
Owner Author

The Build (stable) check failed on da4b701, but the failure is unrelated to this PR's change (only internal/providerfc/common.go/common_test.go were touched here).

TestActionCmd_DownloadFile_404 (in cmd/coverage_test.go, pre-existing on main) calls out to the external https://httpstat.us/404 service and asserts the error contains "404". In this run that service returned 502 Bad Gateway instead:

Error: "download failed with status: 502 Bad Gateway" does not contain "404"

No fix for this exists on main yet (the test relies on a live third-party endpoint, so it's inherently flaky). I've re-run the failed jobs once; if it fails again for the same reason, that's a pre-existing issue outside this PR's scope to fix.


Generated by Claude Code

@cdalar
cdalar merged commit 5881e3b into main Aug 29, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址