Repository navigation
fix: address PR #1059 review feedback on spinner - #1060
Merged
Merged
Conversation
Addresses PR #1059 review feedback: closing done via a goroutine in the non-terminal path was pointless (nothing async happens) and left a stale program reference around; also drops the unrelated branches_report.md that snuck into that PR.
Addresses PR #1059 review feedback: spawning a goroutine just to close done was pointless (nothing async happens) and left s.program pointing at a stale value, so Stop() could later Quit() a program from a prior run.
![chatgpt-codex-connector[bot]](/p/https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3de557245
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
Good catch — verified: Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
donechannel synchronously in the non-terminal path instead of via a throwaway goroutine, and clearss.programthere too, soStop()can't block waiting on scheduling or laterQuit()a stale program.Addresses both review comments left by GitHub Copilot on #1059 after it merged:
Note: an earlier commit on this PR also deleted
docs/branches_report.md, believing it had snuck in via #1059. Codex review correctly flagged that this file was actually added independently by commit11ec412(#1045), unrelated to the spinner fix — it has been restored.Test plan
go build ./...go test ./internal/ui/...