Skip to content

Use Go 1.19 - #96

Merged
saswatamcode merged 1 commit into
bwplotka:mainfrom
abhinav:go119
Oct 26, 2022
Merged

saswatamcode merged 1 commit into
bwplotka:mainfrom
abhinav:go119

Conversation

@abhinav

@abhinav abhinav commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

This raises the go directive in the go.mod file to Go 1.19,
and runs go mod tidy,
which prunes a fair bit of redundant information from the go.sum.

Additionally, this bumps the version of Go used in both GitHub
workflows.

@saswatamcode

saswatamcode commented Oct 13, 2022 •

Copy link
Copy Markdown
Collaborator

Can you regenerate the README on this by running make docs? 🙂

@abhinav

abhinav commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

Done! Weird; I didn't expect it to change with go 1.19.

This raises the `go` directive in the go.mod file to Go 1.19,
runs `go mod tidy`, and bumps the Go version used in GitHub workflows.

`go mod tidy` pruned a fair bit of redundant information from the
go.sum.

Lastly, this runs `make docs` to reformat documentation.
@abhinav abhinav mentioned this pull request Oct 13, 2022
@abhinav

abhinav commented Oct 25, 2022

Copy link
Copy Markdown
Contributor Author

Gentle bump. I'll rebase #98 on top when this merges.

@saswatamcode saswatamcode left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saswatamcode
saswatamcode merged commit 818772c into bwplotka:main Oct 26, 2022
@abhinav
abhinav deleted the go119 branch November 3, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址