Skip to content

Update build - #108

Merged
saswatamcode merged 5 commits into
bwplotka:mainfrom
SuperQ:bot-bot-bot
May 8, 2023
Merged

saswatamcode merged 5 commits into
bwplotka:mainfrom
SuperQ:bot-bot-bot

Conversation

@SuperQ

@SuperQ SuperQ commented May 7, 2023

Copy link
Copy Markdown
Contributor
  • Enable dependabot.
  • Update Go to 1.20.
  • Update bingo.
  • Update golangci-lint.
  • Remove misspell (handled by golangci-lint).

SuperQ added 2 commits May 7, 2023 17:19
* Enable dependabot.
* Update Go to 1.20.
* Update bingo.
* Update golangci-lint.
* Remove misspell (handled by golangci-lint).

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: SuperQ <superq@gmail.com>

@saswatamcode saswatamcode left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Generally LGTM!

I think the "check 404 link" test fails now, due to the new go version printing DNS resolver address with the error. Maybe we can convert https://github.com/bwplotka/mdox/blob/main/pkg/mdformatter/linktransformer/link_test.go#L311 to use testutil.Assert with strings.Contains instead, as that might be simplest way to fix? 🙂

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ

SuperQ commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

@saswatamcode Done, updated test.

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
@saswatamcode

saswatamcode commented May 8, 2023 •

Copy link
Copy Markdown
Collaborator

Ah missed the path! Fixed it.

@saswatamcode
saswatamcode merged commit 486b9cd into bwplotka:main May 8, 2023
@SuperQ
SuperQ deleted the bot-bot-bot branch May 8, 2023 06:07
@SuperQ

SuperQ commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

One thing that can also be done now is switch to the Go 1.20 multi-error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址