Repository navigation
Update build - #108
Merged
Merged
Update build#108
Conversation
SuperQ
commented
May 7, 2023
Contributor
- Enable dependabot.
- Update Go to 1.20.
- Update bingo.
- Update golangci-lint.
- Remove misspell (handled by golangci-lint).
* Enable dependabot. * Update Go to 1.20. * Update bingo. * Update golangci-lint. * Remove misspell (handled by golangci-lint). Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: SuperQ <superq@gmail.com>
saswatamcode
approved these changes
May 8, 2023
saswatamcode
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot! Generally LGTM!
I think the "check 404 link" test fails now, due to the new go version printing DNS resolver address with the error. Maybe we can convert https://github.com/bwplotka/mdox/blob/main/pkg/mdformatter/linktransformer/link_test.go#L311 to use testutil.Assert with strings.Contains instead, as that might be simplest way to fix? 🙂
Signed-off-by: SuperQ <superq@gmail.com>
Contributor
Author
|
@saswatamcode Done, updated test. |
saswatamcode
reviewed
May 8, 2023
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Collaborator
|
Ah missed the path! Fixed it. |
Contributor
Author
|
One thing that can also be done now is switch to the Go 1.20 multi-error handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.