Repository navigation
mdox-exec: Also add newline when non-zero exit code - #103
Merged
Merged
Conversation
saswatamcode
approved these changes
Jan 25, 2023
saswatamcode
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing!
One small suggestion. 🙂
| expectedCode, _ := strconv.Atoi(infoStringAttr[infoStringKeyExitCode]) | ||
| if exitErr, ok := err.(*exec.ExitError); ok && exitErr.ExitCode() == expectedCode { | ||
| return b.Bytes(), nil | ||
| if exitErr, ok := err.(*exec.ExitError); !ok || exitErr.ExitCode() != expectedCode { |
Collaborator
There was a problem hiding this comment.
Maybe we should return a separate error if !ok and exitErr.ExitCode() != expectedCode?
Contributor
Author
There was a problem hiding this comment.
Thanks, I've updated the PR to differentiate these errors.
olivierlemasle
force-pushed
the
fix-eol
branch
from
January 25, 2023 11:09
afed01c to
3dcf0fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new line (
\n) is added at the end ofmdox-execoutput, but only when the exit code is 0 (not when using a non-zeromdox-expect-exit-code):mdox/pkg/mdformatter/mdgen/mdgen.go
Lines 92 to 95 in 53a5104
The new line should always be added (if not present).
Tests are updated to use
echo -n(prints no\n).