This repository was archived by the owner on May 13, 2022. It is now read-only.
Repository navigation
Issue #16 - xxHash Deviations - #17
Merged
Merged
Conversation
xxHash calculated incorrect valuex when in 64-bit mode and the input satisfies: length % 8 == 4. xxHash calculated incorrect values when in either mode and the input length was greater than or equal to 2^31 characters in length. Both of these issues cause breaking changes to any current users of xxHash given the value(s) could satisfy those constraints.
Owner
Author
|
test this please |
Collaborator
|
Refer to this link for build results (access rights to CI server needed): |
brandondahler
added a commit
that referenced
this pull request
Sep 27, 2015
Issue #16 - xxHash Deviations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xxHash calculated incorrect valuex when in 64-bit mode and the input satisfies: length % 8 == 4.
xxHash calculated incorrect values when in either mode and the input length was greater than or equal to 2^31 characters in length.
Both of these issues cause breaking changes to any current users of xxHash given the value(s) could satisfy those constraints.