Repository navigation
Add custom app icons for iOS installs - #260
Merged
Merged
Conversation
Add an optional custom app icon to the install page, the REST API, the WebSocket install message and the MCP install_app tool. The image is validated, normalized to PNG and stored with the installed app record, so every refresh, reinstall and source update signs with the same icon, as requested in #254. Both signing modes pass it to plumesign as --custom-icon=<path>. Refs #254
Drop the byte-identical ResolveStoredCustomIconPath helper and serve the stored custom icon through the existing ResolveAppIconPath, so the 'inside <DataDir>/ipa' policy lives in one place. Also align the new custom_icon locale block indentation with its siblings in en, ru and zh_cn. Refs #254
Move the custom app icon to the left of the app name field, matching the reference layout: a large rounded swatch that opens the image picker when clicked, with a plus placeholder when empty and a remove badge on its top-right corner once an image is chosen. Drop the separate file input and label, and trim the now-unused locale keys. Refs #254
Replace the plus glyph in the empty custom icon swatch with the localized "No icon" placeholder, matching the other empty states. Refs #254
Custom app icons are only applied on iOS (iPhone/iPad) installs; Apple TV ignores plumesign --custom-icon. Hide the picker on the install page for other devices, and skip uploading, prefilling and submitting the icon so an Apple TV install never carries one. Refs #254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Let users customize the icon of sideloaded iPhone and iPad apps, and keep that icon when apps are reinstalled or updated from a source. Apple TV does not support this option, so the picker is hidden for Apple TV devices.
Approach
Use PlumeImpactor's existing
--custom-iconoption. Validate uploaded PNG, JPEG, or GIF images, normalize them to PNG, and store the result with the installed-app record so future installs can reuse it.How it works
POST /api/custom-icon/upload.plumesign --custom-iconin both signing modes, including source updates and reinstalls.Verification
CGO_ENABLED=0 go build ./...CGO_ENABLED=0 go test ./...golangci-lint run --timeout=5mcd web/static && npm run build && npm test(84 tests passed)Links