Skip to content

fix(app): confine deletion to the app's storage directory - #244

Merged
bitxeno merged 2 commits into
bitxeno:masterfrom
YellowNest:fix/delete-app-owned-directory
Oct 30, 2026
Merged

bitxeno merged 2 commits into
bitxeno:masterfrom
YellowNest:fix/delete-app-owned-directory

Conversation

@YellowNest

@YellowNest YellowNest commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Deleting an app could remove unrelated files by using the parent directory of its stored IPA path.

Fix

Restrict deletion to the app-owned storage directory. Reject deletion safely when the storage root is not configured.

Verification

  • Frontend: 77/77 tests passed.
  • Frontend production build passed.
  • Full Go test suite passed with Go 1.25.
  • Previously failing signing identity deletion test now passes.
  • GitHub Actions build and golangci-lint passed.
  • Race detector: blocked by a known 47-bit VMA incompatibility on the ARM64 test host. No race-test pass is claimed.

No live-device integration test was performed.

@YellowNest
YellowNest marked this pull request as ready for review October 29, 2026 10:57
@bitxeno
bitxeno merged commit 196e52d into bitxeno:master Oct 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址